mapleFU commented on code in PR #34961:
URL: https://github.com/apache/arrow/pull/34961#discussion_r1163986422
##########
cpp/src/arrow/testing/random.cc:
##########
@@ -793,7 +793,7 @@ std::shared_ptr<Array> RandomArrayGenerator::ArrayOf(const
Field& field, int64_t
values_length, alignment, memory_pool);
\
const auto offsets = OffsetsFromLengthsArray(lengths.get(),
force_empty_nulls, \
alignment, memory_pool);
\
- return *ARRAY_TYPE::FromArrays(*offsets, *values);
\
+ return *ARRAY_TYPE::FromArrays(field.type(), *offsets, *values);
\
Review Comment:
Yes, this patch brings `List` and `Struct` into alignment. For testing, I
also tests map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
