alamb commented on code in PR #5775:
URL: https://github.com/apache/arrow-datafusion/pull/5775#discussion_r1161758436
##########
datafusion/substrait/tests/roundtrip_logical_plan.rs:
##########
@@ -333,6 +405,23 @@ mod tests {
Ok(())
}
+ async fn roundtrip_all_types(sql: &str) -> Result<()> {
Review Comment:
I think the `::boolean` syntax is in terms of SQL types (not Arrow types).
The SQL --> Arrow type mapping are in
https://arrow.apache.org/datafusion/user-guide/sql/data_types.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
