alamb commented on code in PR #5775:
URL: https://github.com/apache/arrow-datafusion/pull/5775#discussion_r1161788549
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -910,20 +908,196 @@ fn from_substrait_bound(
}
}
+fn from_substrait_literal(lit: &Literal) -> Result<ScalarValue> {
+ let scalar_value = match &lit.literal_type {
+ Some(LiteralType::Boolean(b)) => ScalarValue::Boolean(Some(*b)),
+ Some(LiteralType::I8(n)) => match lit.type_variation_reference {
+ DEFAULT_TYPE_REF => ScalarValue::Int8(Some(*n as i8)),
+ UNSIGNED_INTEGER_TYPE_REF => ScalarValue::UInt8(Some(*n as u8)),
+ others => {
+ return Err(DataFusionError::Substrait(format!(
+ "Unknown type variation reference {others}",
+ )));
+ }
+ },
+ Some(LiteralType::I16(n)) => match lit.type_variation_reference {
+ DEFAULT_TYPE_REF => ScalarValue::Int16(Some(*n as i16)),
+ UNSIGNED_INTEGER_TYPE_REF => ScalarValue::UInt16(Some(*n as u16)),
+ others => {
+ return Err(DataFusionError::Substrait(format!(
+ "Unknown type variation reference {others}",
+ )));
+ }
+ },
+ Some(LiteralType::I32(n)) => match lit.type_variation_reference {
+ DEFAULT_TYPE_REF => ScalarValue::Int32(Some(*n)),
+ UNSIGNED_INTEGER_TYPE_REF => ScalarValue::UInt32(Some(unsafe {
Review Comment:
I think I found a way to remove the unsafe code, see
https://github.com/apache/arrow-datafusion/pull/5946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
