icexelloss commented on code in PR #35005:
URL: https://github.com/apache/arrow/pull/35005#discussion_r1161774402
##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -5475,7 +5475,7 @@ TEST(Substrait, AsOfJoinDefaultEmit) {
}
}
},
- "names": ["time", "key", "value1", "time2", "key2", "value2"]
Review Comment:
Actually I see - this is the correct output schema. @rtpsw Did you test this
with internal code? I think we also need to update our ibis-substrait producer
to produce an emit outputting that matches this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
