icexelloss commented on code in PR #35005:
URL: https://github.com/apache/arrow/pull/35005#discussion_r1161798156
##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -5475,7 +5475,7 @@ TEST(Substrait, AsOfJoinDefaultEmit) {
}
}
},
- "names": ["time", "key", "value1", "time2", "key2", "value2"]
Review Comment:
> No, I haven't tested this code internally yet. Do you want this test done
before proceeding here? I agree the Substrait producer would have to change.
Yeah I think so. We want to make sure internal code can work with change we
make here (with slight modification)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
