jorisvandenbossche commented on code in PR #35036:
URL: https://github.com/apache/arrow/pull/35036#discussion_r1162645546
##########
cpp/src/arrow/compute/kernels/scalar_validity.cc:
##########
@@ -102,6 +104,15 @@ Status IsNullExec(KernelContext* ctx, const ExecSpan&
batch, ExecResult* out) {
bit_util::SetBitsTo(out_bitmap, out_span->offset, out_span->length, false);
}
+ const auto t = arr.type->id();
+ if (t == Type::SPARSE_UNION) {
+ union_util::SetLogicalSparseUnionNullBits(arr, out_bitmap,
out_span->offset);
Review Comment:
I followed the same pattern as we had for `SetNanBits` (used just below,
i.e. updating the previously created bitmap), not that this is necessarily the
best approach though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
