felipecrv commented on code in PR #35036: URL: https://github.com/apache/arrow/pull/35036#discussion_r1163246055
########## cpp/src/arrow/util/union_util.h: ########## @@ -27,5 +27,11 @@ int64_t LogicalSparseUnionNullCount(const ArraySpan& span); /// \brief Compute the number of of logical nulls in a dense union array int64_t LogicalDenseUnionNullCount(const ArraySpan& span); +void SetLogicalSparseUnionNullBits(const ArraySpan& span, uint8_t* out_bitmap, + int64_t out_offset); + +void SetLogicalDenseUnionNullBits(const ArraySpan& span, uint8_t* out_bitmap, + int64_t out_offset); Review Comment: Moving these to `scalar_validity.cc` frees you from having to document them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
