yevgenypats commented on code in PR #34986:
URL: https://github.com/apache/arrow/pull/34986#discussion_r1163256914
##########
go/arrow/array/binarybuilder_test.go:
##########
@@ -50,11 +51,16 @@ func TestBinaryBuilder(t *testing.T) {
}
assert.Equal(t, v, ab.Value(i), "unexpected
BinaryArrayBuilder.Value(%d)", i)
}
+ // Zm9v is foo in base64
+ assert.NoError(t, ab.AppendValueFromString("Zm9v"))
ar := ab.NewBinaryArray()
+ assert.Equal(t, "Zm9v", ar.ValueString(5))
+
ab.Release()
ar.Release()
+
Review Comment:
Sure. BTW - maybe we should open an issue on adding a linter that runs fmt
on all files as a pre-set ? this way it wont need review as I'll be able to
just see in the CI. WDYT ? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
