yevgenypats commented on code in PR #34986:
URL: https://github.com/apache/arrow/pull/34986#discussion_r1164340677
##########
go/arrow/array/binarybuilder.go:
##########
@@ -289,6 +289,26 @@ func (b *BinaryBuilder) appendNextOffset() {
b.appendOffsetVal(numBytes)
}
+func (b *BinaryBuilder) AppendValueFromString(s string) error {
+ if s == NullValueStr {
+ b.AppendNull()
+ return nil
+ }
+ switch b.dtype.ID() {
+ case arrow.BINARY, arrow.LARGE_BINARY:
+ decodedVal, err := base64.StdEncoding.DecodeString(s)
+ if err != nil {
+ return fmt.Errorf("could not decode base64 string: %w",
err)
+ }
Review Comment:
hmm. I think we should try to always use `std` otherwise this fallback will
propagate everywhere because we want catch if someone encoded something with
`RawStdEncoding` instead of `StdEncoding`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
