chitralverma commented on issue #4047: URL: https://github.com/apache/arrow-rs/issues/4047#issuecomment-1504034546
> > doesn't 'from_env' imply that most creds, options will come from env and that env vars should be preferred? > > It might :) - but from what I see there is no way to tell the user intent inside the proposed `parse_url` function. I.e. we would be making the decision to call `from_env`, not the user. If I as a user pass in configuration for a specific credential, I would expect that to be used, and not overwritten by the environment. > > I guess thats why it might just be best to just let the caller figure that out, to keep things simpler for now. If we see a solution emerging in several protects, we can still move that upstream? or wait, my bad i didn't see the from_env in the snippet. for this PR, i would like to keep it very simple - Given a URL and storage options, a user should be able to instantiate an object store. so this PR can be separated from the registry part and the env part - nothing is to be read from the env for the registries - I think it should still be a part of the projects, because they all may want to handle this their own way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
