berkaysynnada opened a new pull request, #5971:
URL: https://github.com/apache/arrow-datafusion/pull/5971
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #5844.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Currently, interval arithmetic operations are not supported for temporal
datatypes. It is especially necessary to be able to apply symmetric hash join
over ordered timestamp columns, probably with some interval differences.
With this PR, we can make use of interval arithmetic with Interval-Interval
and Timestamp-Timestamp intervals. Also, evalute_array function (where array vs
scalar operations go to in datetime.rs) had a limited evaluation ability. It
has a similar behavior now with [that feature
](https://github.com/apache/arrow-datafusion/pull/5764).
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
evaluate_array is extended to make timestamp vs timestamp, timestamp vs
interval, and interval vs interval calculations, and dangerous unwraps are
removed. min/max of different interval types can be found now.
`evaluate_bounds` and `propagate_constraints` are implemented for
`DateTimeIntervalExpr`.
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes, symmetric hash join tests are extended with temporal datatypes.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
