berkaysynnada commented on PR #5971: URL: https://github.com/apache/arrow-datafusion/pull/5971#issuecomment-1508044222
> Thank you @berkaysynnada and @mustafasrepo -- I didn't review this PR fully but I think the structure looks good to me. > > My biggest concern in the entire exercise is that the arithmetic that is supported for ScalarValue and what is supported for Arrays (and what is supported upstream in arrow-rs) will diverge. However I think we are all agreed on the desired end state (kernels in arrow-rs and the same math / support for scalars in Datafusion) Thank you for the review. Once you review and approve the [structure](https://github.com/synnada-ai/arrow-datafusion/pull/83), I will move the other arithmetic codes that are for Arrays, and finally, I believe we can unify all arithmetics in kernels_arrow.rs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
