NoahFournier commented on code in PR #35034:
URL: https://github.com/apache/arrow/pull/35034#discussion_r1163892759
##########
java/dataset/src/main/java/org/apache/arrow/dataset/file/JniWrapper.java:
##########
@@ -45,6 +45,17 @@ private JniWrapper() {
*/
public native long makeFileSystemDatasetFactory(String uri, int fileFormat);
+ /**
+ * Create FileSystemDatasetFactory and return its native pointer. The
pointer is pointing to a
+ * intermediate shared_ptr of the factory instance.
+ *
+ * @param uris List of file uris to read, each path pointing to an
individual file
Review Comment:
It will only work for specific individual files, and confirmed this by
testing locally. I believe this matches the behaviour of the arrow C++
libraries. We would need to use a selector in order to crawl a directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
