NoahFournier commented on code in PR #35034:
URL: https://github.com/apache/arrow/pull/35034#discussion_r1165196008
##########
java/dataset/src/main/java/org/apache/arrow/dataset/file/JniWrapper.java:
##########
@@ -45,6 +45,17 @@ private JniWrapper() {
*/
public native long makeFileSystemDatasetFactory(String uri, int fileFormat);
+ /**
+ * Create FileSystemDatasetFactory and return its native pointer. The
pointer is pointing to a
+ * intermediate shared_ptr of the factory instance.
+ *
+ * @param uris List of file uris to read, each path pointing to an
individual file
Review Comment:
The `String, int` overload correctly handles the user passing a directory,
which the `String[], int` overload does not (Each `String` needs to be a
complete uri to a source). I'll look into whether I could handle both
directories and complete URIs in the `String[], int` implementation, in which
case we wouldn't need `String, int`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
