GregBowyer commented on a change in pull request #8698:
URL: https://github.com/apache/arrow/pull/8698#discussion_r534655770
##########
File path: rust/parquet/src/encodings/decoding.rs
##########
@@ -384,36 +278,18 @@ impl<T: DataType> Decoder<T> for DictDecoder<T> {
/// See [`RleValueEncoder`](crate::encoding::RleValueEncoder) for more
information.
pub struct RleValueDecoder<T: DataType> {
values_left: usize,
- decoder: Option<RleDecoder>,
+ decoder: RleDecoder,
Review comment:
Performance Notes:
Small and minor this gives a 5% boost on performance as the RLE encoder can
just be established before use without needing to constantly check if it has
been initialised for every value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
