GregBowyer commented on a change in pull request #8698:
URL: https://github.com/apache/arrow/pull/8698#discussion_r534656244
##########
File path: rust/parquet/src/encodings/encoding.rs
##########
@@ -130,6 +130,7 @@ impl<T: DataType> PlainEncoder<T> {
}
impl<T: DataType> Encoder<T> for PlainEncoder<T> {
+ #[cold]
Review comment:
Performance Notes:
As far as I can tell these functions are rarely called and as such we can
hint to the compiler that they dont need to be folded into hot locations in the
final output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
