Jefffrey commented on code in PR #6025:
URL: https://github.com/apache/arrow-datafusion/pull/6025#discussion_r1167817065
##########
datafusion/expr/src/aggregate_function.rs:
##########
@@ -77,30 +77,34 @@ impl FromStr for AggregateFunction {
type Err = DataFusionError;
fn from_str(name: &str) -> Result<AggregateFunction> {
Ok(match name {
- "min" => AggregateFunction::Min,
- "max" => AggregateFunction::Max,
- "count" => AggregateFunction::Count,
+ // general
Review Comment:
just reorganizing, to be similar to how it looks in the sql doc, and group
them together here a bit better
##########
datafusion/expr/src/built_in_function.rs:
##########
@@ -313,12 +313,13 @@ impl FromStr for BuiltinScalarFunction {
// math functions
"abs" => BuiltinScalarFunction::Abs,
"acos" => BuiltinScalarFunction::Acos,
- "asin" => BuiltinScalarFunction::Asin,
- "atan" => BuiltinScalarFunction::Atan,
"acosh" => BuiltinScalarFunction::Acosh,
+ "asin" => BuiltinScalarFunction::Asin,
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
