alamb commented on code in PR #6025:
URL: https://github.com/apache/arrow-datafusion/pull/6025#discussion_r1168491345


##########
docs/source/user-guide/sql/select.md:
##########
@@ -83,7 +83,7 @@ SELECT a FROM table WHERE a > 10
 
 ## JOIN clause
 
-DataFusion supports `INNER JOIN`, `LEFT OUTER JOIN`, `RIGHT OUTER JOIN`, `FULL 
OUTER JOIN`, and `CROSS JOIN`.
+DataFusion supports `INNER JOIN`, `LEFT OUTER JOIN`, `RIGHT OUTER JOIN`, `FULL 
OUTER JOIN`, `NATURAL JOIN` and `CROSS JOIN`.

Review Comment:
   We also support SEMI JOIN and ANTI Join (can be documented in some other PR)
   
   ```
   ❯ create table foo(x int) as values (1);
   0 rows in set. Query took 0.009 seconds.
   ❯ create table bar(x int) as values (1);
   0 rows in set. Query took 0.001 seconds.
   ❯ select foo.x from foo left semi join bar using (x);
   +---+
   | x |
   +---+
   | 1 |
   ```



##########
docs/source/user-guide/sql/ddl.md:
##########
@@ -19,6 +19,32 @@
 
 # DDL
 
+## CREATE DATABASE
+
+Create catalog with specified name.
+
+<pre>
+CREATE DATABASE [ IF NOT EXISTS ] <i><b>catalog</i></b>
+</pre>
+
+```sql
+-- create catalog cat
+CREATE DATABASE cat;
+```
+
+## CREATE SCHEMA
+
+Create schema under specified catalog, or the default DataFusion catalog if 
not specified.
+
+<pre>
+CREATE SCHEMA [ IF NOT EXISTS ] [ <i><b>catalog.</i></b> ] 
<b><i>schema_name</i></b>
+</pre>
+
+```sql
+-- create schema emu under catalog cat
+CREATE SCHEMA cat.emu;
+```

Review Comment:
   I didn't know this worked ❤️  but I tried it out 
   
   ```
   8 rows in set. Query took 0.014 seconds.
   ❯ create table cat.emu.dog(x int);
   0 rows in set. Query took 0.000 seconds.
   ❯ show tables;
   +---------------+--------------------+-------------+------------+
   | table_catalog | table_schema       | table_name  | table_type |
   +---------------+--------------------+-------------+------------+
   | cat           | emu                | dog         | BASE TABLE |
   | cat           | information_schema | tables      | VIEW       |
   | cat           | information_schema | views       | VIEW       |
   | cat           | information_schema | columns     | VIEW       |
   | cat           | information_schema | df_settings | VIEW       |
   | datafusion    | information_schema | tables      | VIEW       |
   | datafusion    | information_schema | views       | VIEW       |
   | datafusion    | information_schema | columns     | VIEW       |
   | datafusion    | information_schema | df_settings | VIEW       |
   +---------------+--------------------+-------------+------------+
   9 rows in set. Query took 0.001 seconds.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to