mingmwang commented on PR #6003: URL: https://github.com/apache/arrow-datafusion/pull/6003#issuecomment-1510956988
> I had a comment for refactoring `col_to_scalar` function. It simplifies the code and removes duplication. Is there a specific reason for not doing so? Maybe I misunderstood what `col_to_scalar` does. Without this change we may have diverging versions of similar code in `row_hash.rs` and `scalar.rs`. One may change one of them, and corresponding change may be missing in other file. Yes, I will change accordingly per your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
