mingmwang commented on code in PR #6003:
URL: https://github.com/apache/arrow-datafusion/pull/6003#discussion_r1169583884
##########
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##########
@@ -491,6 +491,55 @@ impl GroupedHashAggregateStream {
Ok(())
}
+ // Update the accumulator results, according to row_aggr_state.
+ fn update_accumulators_using_scalar(
+ &mut self,
+ groups_with_rows: &[usize],
+ row_values: &[Vec<ArrayRef>],
+ row_filter_values: &[Option<ArrayRef>],
+ ) -> Result<()> {
+ let filter_bool_array = row_filter_values
+ .iter()
+ .map(|filter_opt| match filter_opt {
+ Some(f) => Ok(Some(as_boolean_array(f)?)),
Review Comment:
the `as_boolean_array` returns a Result here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
