rtpsw commented on PR #34392: URL: https://github.com/apache/arrow/pull/34392#issuecomment-1511686036
> Why would the code later unable to detect that the current time is invalid? (I assume this is invalid because it hasn't got any input?) Detecting is not good enough. `GetCurrentTime()` needs a valid time when called, so there needs to be code that ensures this. The `MemoStore` constructor can't do this because at that time there is no input yet. > This is surprising - why would this happen in serial execution? And what evidence makes you believe this is happening? I don't (yet?) have evidence to directly support this. What I noted is evidence against the race condition being due to the process thread, and so I suspect the order of input batches. I suspect that when a node has at least two inputs, the order of batches to that node (i.e., across its inputs) may still be non-deterministic even with serial execution. Perhaps @westonpace can shed some light here, or we could investigate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
