rtpsw commented on PR #34392: URL: https://github.com/apache/arrow/pull/34392#issuecomment-1512701578
> Another potential source of contention / race conditions is the interplay between `InputReceived` and the process thread. Normally `InputReceived` runs first and then the process thread runs afterwards. However, if the process thread is currently processing, it might run at the same time as `InputReceived` and there could be potential race conditions on the state. Though I'm pretty sure you're aware of this already :) Indeed I'm aware. This scenario doesn't cause trouble because [the `InputReceived` method](https://github.com/apache/arrow/blob/a2548a79a191c280966d869c7778643fd64fdcd6/cpp/src/arrow/acero/asof_join_node.cc#L1503-L1513) basically just pushes a batch to the queue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
