wjones127 commented on code in PR #35183:
URL: https://github.com/apache/arrow/pull/35183#discussion_r1169291035
##########
csharp/test/Apache.Arrow.Tests/Decimal128ArrayTests.cs:
##########
@@ -41,7 +40,7 @@ public void AppendThenGetGivesNull()
var array = builder.Build();
Assert.Equal(3, array.Length);
- Assert.Equal(array.Data.Buffers[1].Length, array.ByteWidth
* 3);
+ Assert.Equal(array.Data.Buffers[1].Length, array.ByteWidth
* 3 + array.ByteWidth - 1);
Review Comment:
What is the purpose of this PR? It seems like it makes this computation
unnecessarily complex. Decimals are either 16 or 32 bytes per the Arrow
specification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
