Platob commented on code in PR #35183:
URL: https://github.com/apache/arrow/pull/35183#discussion_r1169532257
##########
csharp/test/Apache.Arrow.Tests/Decimal128ArrayTests.cs:
##########
@@ -41,7 +40,7 @@ public void AppendThenGetGivesNull()
var array = builder.Build();
Assert.Equal(3, array.Length);
- Assert.Equal(array.Data.Buffers[1].Length, array.ByteWidth
* 3);
+ Assert.Equal(array.Data.Buffers[1].Length, array.ByteWidth
* 3 + array.ByteWidth - 1);
Review Comment:
yeah indeed seeing cpp implementation its fixed
I saw in ParquetSharp implementation returning a Decimal128Type with 9
byteWidth for precision = 15 and scale = 5 which was different from 16
I wonder why its fixed since it could use way less memory for small numbers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
