kou commented on code in PR #35196:
URL: https://github.com/apache/arrow/pull/35196#discussion_r1169408189
##########
cpp/src/arrow/ArrowConfig.cmake.in:
##########
@@ -101,7 +101,7 @@ if(TARGET Arrow::arrow_static AND NOT TARGET
Arrow::arrow_bundled_dependencies)
foreach(CONFIGURATION ${arrow_static_configurations})
string(TOUPPER "${CONFIGURATION}" CONFIGURATION)
get_target_property(arrow_static_location Arrow::arrow_static
- LOCATION_${CONFIGURATION})
+ IMPORTED_LOCATION_${CONFIGURATION})
Review Comment:
Do you have any preference between `LOCATION_<CONFIG>` and
`IMPORTED_LOCATION_<CONFIG>`?
I prefer `LOCATION_<CONFIG>` to `IMPORTED_LOCATION_<CONFIG>` because
https://cmake.org/cmake/help/latest/prop_tgt/IMPORTED_LOCATION.html mentions
`LOCATION_<CONFIG>` not `IMPORTED_LOCATION_<CONFIG>`.
But it's not a strong opinion. If you prefer `LOCATION_<CONFIG>`, please
revert this change before we merge this. If you prefer
`IMPORTED_LOCATION_<CONFIG>`, we can merge this as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
