assignUser commented on code in PR #35196:
URL: https://github.com/apache/arrow/pull/35196#discussion_r1169411631
##########
cpp/src/arrow/ArrowConfig.cmake.in:
##########
@@ -101,7 +101,7 @@ if(TARGET Arrow::arrow_static AND NOT TARGET
Arrow::arrow_bundled_dependencies)
foreach(CONFIGURATION ${arrow_static_configurations})
string(TOUPPER "${CONFIGURATION}" CONFIGURATION)
get_target_property(arrow_static_location Arrow::arrow_static
- LOCATION_${CONFIGURATION})
+ IMPORTED_LOCATION_${CONFIGURATION})
Review Comment:
I don't have a strong opinion _but_ (nitpicking ahead) I am reading the
cmake docs in a way that leads me to believe setting the
`IMPORTED_LOCATION_<CONFIG>` is the "right" thing:
[`LOCATION_<CONFIG>`](https://cmake.org/cmake/help/latest/prop_tgt/LOCATION_CONFIG.html):
> Read-only property providing a target location on disk.
IMO this mean it should not be set directly but rather using
`IMPORTED_LOCATION_<CONFIG>` as the docs for
[`IMPORTED_LOCATION`](https://cmake.org/cmake/help/latest/prop_tgt/IMPORTED_LOCATION.html)
say:
> The IMPORTED_LOCATION target property may be overridden for a given
configuration <CONFIG> by the configuration-specific
[IMPORTED_LOCATION_\<CONFIG\>](https://cmake.org/cmake/help/latest/prop_tgt/IMPORTED_LOCATION_CONFIG.html#prop_tgt:IMPORTED_LOCATION_%3CCONFIG%3E)
target property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
