jorgecarleitao commented on a change in pull request #8821:
URL: https://github.com/apache/arrow/pull/8821#discussion_r536296786
##########
File path: .github/workflows/rust.yml
##########
@@ -21,145 +21,286 @@ on:
push:
paths:
- '.github/workflows/rust.yml'
- - 'ci/docker/*rust*'
- - 'ci/scripts/rust_*.sh'
- - 'ci/scripts/util_*.sh'
- 'rust/**'
- 'format/Flight.proto'
pull_request:
paths:
- '.github/workflows/rust.yml'
- - 'ci/docker/*rust*'
- - 'ci/scripts/rust_*.sh'
- - 'ci/scripts/util_*.sh'
- 'rust/**'
- 'format/Flight.proto'
-env:
- DOCKER_BUILDKIT: 0
- COMPOSE_DOCKER_CLI_BUILD: 1
- ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
- ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
-
jobs:
- debian:
- name: AMD64 Debian 10 Rust ${{ matrix.rust }}
+ # build the library, a compilation step used by multiple steps below
+ linux-build-lib:
+ name: Linux ${{ matrix.arch }} Rust ${{ matrix.rust }} build libraries
Review comment:
Agreed. The issue with hard-coding AMD64 is that it does not depend on
`${{ matrix.arch }}`. Would it be ok to be amd64, since that is the name of the
image?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
