jorgecarleitao commented on a change in pull request #8821:
URL: https://github.com/apache/arrow/pull/8821#discussion_r536378073
##########
File path: docker-compose.yml
##########
@@ -903,35 +902,6 @@ services:
/bin/bash -c "
/arrow/ci/scripts/r_sanitize.sh /arrow"
- ################################ Rust #######################################
-
- debian-rust:
Review comment:
The arguments I used to remove it:
* this compose and associated dockerfile are no longer tested under the CI,
and their primary purpose was to be used in the CI
* the dockerfile is not needed, as the default rust image is sufficient
* the compose contains non-trivial aspects, such as:
* volume mounting with `delegate`
* using the no-longer needed `rust_test.sh`
* non-default `CARGO_*` env variables
* `docker-compose run debian-rust` is IMO less transparent to a user about
what is happening, and the person needs to go to a +1k LOC file to understand.
In opposition, this whole project can now be built using
```bash
docker run --rm -v $(pwd)/rust:/rust -it rust /bin/bash -c "cd /rust &&
cargo build"
```
which IMO is really simple to understand and reproduce. Wouldn't this
command on the README be sufficient for contributors?
In the end, I evaluated that having these around would be more confusing
than just having the user to follow standard rust practices of building a rust
project (including using the official docker image), and therefore there was no
need for the maintenance burden of having these around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
