jeremyosterhoudt commented on code in PR #35222:
URL: https://github.com/apache/arrow/pull/35222#discussion_r1172022243
##########
csharp/test/Apache.Arrow.Flight.TestWeb/FlightHolder.cs:
##########
@@ -56,7 +56,7 @@ public FlightInfo GetFlightInfo()
new FlightEndpoint(new
FlightTicket(_flightDescriptor.Paths.FirstOrDefault()), new
List<FlightLocation>(){
new FlightLocation(_location)
})
- });
+ }, 2, 4);
Review Comment:
There is an existing test that verifies all of the properties, but it's not
obvious unless you dig into it. The test has a few assumptions baked into test
flight server that is spun up on startup that make it hard to inject an
expected amount.
However, I was able enhanced the test server to calculate the batch length
and total bytes. I've also added an additional test to ensure those values
match what is expected for those fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
