jeremyosterhoudt commented on code in PR #35222:
URL: https://github.com/apache/arrow/pull/35222#discussion_r1172979803
##########
csharp/src/Apache.Arrow.Flight/FlightInfo.cs:
##########
@@ -64,7 +64,9 @@ internal Protocol.FlightInfo ToProtocol()
var response = new Protocol.FlightInfo()
{
Schema = serializedSchema,
- FlightDescriptor = Descriptor.ToProtocol()
+ FlightDescriptor = Descriptor.ToProtocol(),
+ TotalBytes = TotalBytes,
+ TotalRecords = TotalRecords
Review Comment:
I agree with this as it makes it clear they are unset. The handling is a
little inconsistent language to language, Java makes you pass the values while
C++ defaults to whatever the compiler uses for an unset int in a struct
(normally 0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
