mapleFU commented on PR #35242: URL: https://github.com/apache/arrow/pull/35242#issuecomment-1517491968
@westonpace Hi Pace, I find that `current_page_header_` message Deserialize will not mark `__isset` field to unset when meet a new message. When I change to use a new header, `TestArrowWriteDictionary.Statistics` failed. And when I go through this unittest, I found that I give a wrong stats. For test index: ```C++ ArrayFromJSON(::arrow::int32(), R"([0, 1, null, 0, 1, null])"), ``` It generate: ``` RowGroup1 [ Page1 [0, 1] Page2 [ null ] ] RowGroup2 [ Page1 [0, 1] Page2 [ null ] ] ``` So, I think page2 should not have min-max stats, and I fix it here. Would you mind take a look at this patch? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
