mapleFU commented on code in PR #35242:
URL: https://github.com/apache/arrow/pull/35242#discussion_r1176135459
##########
cpp/src/parquet/file_deserialize_test.cc:
##########
@@ -814,6 +834,30 @@ TEST_F(TestPageSerde, DictCrcCheckNonExistent) {
/* verification_checksum */ true, /* has_dictionary
*/ true);
}
+TEST_F(TestPageSerde, DataPageV2CrcCheckSuccessful) {
Review Comment:
> Should we also add test with `has_dictionary=true` for completeness?
I don't think it will test more code. DICT_PAGE is different from data page.
Testing for them is different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
