jaylmiller commented on code in PR #6096:
URL: https://github.com/apache/arrow-datafusion/pull/6096#discussion_r1174611675
##########
datafusion/common/src/table_reference.rs:
##########
@@ -450,3 +450,39 @@ mod tests {
);
}
}
+
+#[derive(Debug, Clone, PartialEq, Eq, Hash, PartialOrd, Ord)]
+pub enum SchemaReference<'a> {
+ Bare {
+ schema: Cow<'a, str>,
+ },
+ Full {
+ schema: Cow<'a, str>,
+ catalog: Cow<'a, str>,
+ },
+}
+
+pub type OwnedSchemaReference = SchemaReference<'static>;
Review Comment:
I actually think this might make more sense in a separate PR to reduce the
surface area of code changed in this PR since this PR is already pretty big.
I'm open to either though. What do you think? @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
