jaylmiller commented on code in PR #6096:
URL: https://github.com/apache/arrow-datafusion/pull/6096#discussion_r1176885742
##########
datafusion/core/src/execution/context.rs:
##########
@@ -676,6 +701,53 @@ impl SessionContext {
Ok(false)
}
+ /// Attempts to find a schema and deregister it. Returns a tuple of the
schema and a
+ /// flag indicating whether dereg was performed (e.g if schema is found
but has tables
+ /// then `cascade` must be set)
+ fn find_and_deregister_schema<'a>(
Review Comment:
Hmm that is a good point. I was trying to keep the signature as similar as
possible to the other Catalog's `deregister` methods. But you are right that it
could make sense to do it like this. The code within the context provider is a
bit complex at the moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
