crepererum commented on code in PR #4120:
URL: https://github.com/apache/arrow-rs/pull/4120#discussion_r1176456377
##########
object_store/src/client/retry.rs:
##########
@@ -192,11 +192,20 @@ impl RetryExt for reqwest::RequestBuilder {
},
Err(e) =>
{
- return Err(Error{
- retries,
- message: "request error".to_string(),
- source: Some(e)
- })
+ if retries == max_retries
+ || now.elapsed() > retry_timeout
+ || !e.is_request() {
Review Comment:
I agree that only server side (5xx) and transport errors should be retried,
not all error codes. Esp. client side errors (4xx) should NOT be blindly
retried.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
