kindly commented on code in PR #4120:
URL: https://github.com/apache/arrow-rs/pull/4120#discussion_r1176924910
##########
object_store/src/client/retry.rs:
##########
@@ -192,11 +192,20 @@ impl RetryExt for reqwest::RequestBuilder {
},
Err(e) =>
{
- return Err(Error{
- retries,
- message: "request error".to_string(),
- source: Some(e)
- })
+ if retries == max_retries
+ || now.elapsed() > retry_timeout
+ || !e.is_request() {
Review Comment:
@crepererum
These retries only cover cases where there is no response at all, therefore
no response codes at all. The retry condition for requests with responses is
`is_server_error` which I assume means 5xx errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
