tustvold commented on code in PR #4133:
URL: https://github.com/apache/arrow-rs/pull/4133#discussion_r1177654582
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -194,32 +194,150 @@ impl InferredDataType {
}
/// Updates the [`InferredDataType`] with the given string
- fn update(&mut self, string: &str, datetime_re: Option<&Regex>) {
+ fn update(&mut self, string: &str) {
self.packed |= if string.starts_with('"') {
1 << 8 // Utf8
} else if let Some(m) = REGEX_SET.matches(string).into_iter().next() {
1 << m
} else {
- match datetime_re {
- // Timestamp(Nanosecond)
- Some(d) if d.is_match(string) => 1 << 7,
- _ => 1 << 8, // Utf8
- }
+ 1 << 8 // Utf8
Review Comment:
https://github.com/apache/arrow-rs/pull/4133/files#diff-cff6608ea5fd4124751d5878e0f3c318e8117e753c978452d40dd5a6fe7c30d4L2338
contains the relevant tests, there was no prior testing of the datetime_re
logic, you are correct, this is why it has been broken since #3746 (#4129)
without anybody noticing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
