tustvold commented on code in PR #4133:
URL: https://github.com/apache/arrow-rs/pull/4133#discussion_r1178987025
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -194,32 +194,150 @@ impl InferredDataType {
}
/// Updates the [`InferredDataType`] with the given string
- fn update(&mut self, string: &str, datetime_re: Option<&Regex>) {
+ fn update(&mut self, string: &str) {
self.packed |= if string.starts_with('"') {
1 << 8 // Utf8
} else if let Some(m) = REGEX_SET.matches(string).into_iter().next() {
1 << m
} else {
- match datetime_re {
- // Timestamp(Nanosecond)
- Some(d) if d.is_match(string) => 1 << 7,
- _ => 1 << 8, // Utf8
- }
+ 1 << 8 // Utf8
Review Comment:
This PR makes no changes to the inference logic that had test coverage, it
removes functionality that was not tested (and was broken) and therefore does
not impact any of the existing tests. I linked to the existing test coverage
for functionality that has not been changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
