comphead commented on code in PR #6106:
URL: https://github.com/apache/arrow-datafusion/pull/6106#discussion_r1178012180
##########
datafusion/core/src/execution/context.rs:
##########
@@ -259,13 +259,29 @@ impl SessionContext {
Ok(())
}
- /// Creates a new `SessionContext` using the provided session
configuration.
+ /// Creates a new `SessionContext` using the provided
+ /// [`SessionConfig`] and a new [`RuntimeEnv`].
+ ///
+ /// See [`Self::with_config_rt`] for more details on resource
+ /// limits.
pub fn with_config(config: SessionConfig) -> Self {
let runtime = Arc::new(RuntimeEnv::default());
Self::with_config_rt(config, runtime)
}
- /// Creates a new `SessionContext` using the provided [`SessionConfig`]
and [`RuntimeEnv`].
+ /// Creates a new `SessionContext` using the provided
+ /// [`SessionConfig`] and a [`RuntimeEnv`].
+ ///
+ /// # Resource Limits
+ ///
+ /// By default, each new `SessionContext` creates a new
+ /// `RuntimeEnv`, and therefore will not enforce memory or disk
+ /// limits for queries run on different `SessionContext`s.
+ ///
+ /// To enforce resource limits (e.g. to limit the total amount of
Review Comment:
great, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
