seddonm1 commented on a change in pull request #8831:
URL: https://github.com/apache/arrow/pull/8831#discussion_r537120509
##########
File path: rust/datafusion/src/datasource/csv.rs
##########
@@ -104,4 +105,8 @@ impl TableProvider for CsvFile {
batch_size,
)?))
}
+
+ fn statistics(&self) -> Option<Statistics> {
+ unimplemented!()
Review comment:
I thought that you would add statistics to the structs:
```rust
/// Table-based representation of a `ParquetFile`.
pub struct ParquetTable {
path: String,
schema: SchemaRef,
statistics: Option<Statistics>,
}
```
and the `statistics` method would just return the `Option<Statistics>`:
```rust
fn statistics(&self) -> Option<Statistics> {
self.statistics.clone()
}
```
and `statistics` would initially be instantiated as `None` until we
implement it for each source:
```rust
Ok(Self {
path: path.to_string(),
schema,
statistics: None,
})
```
I am new to rust but this is what you were thinking @andygrove ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
