seddonm1 commented on a change in pull request #8831:
URL: https://github.com/apache/arrow/pull/8831#discussion_r537152984



##########
File path: rust/datafusion/src/datasource/datasource.rs
##########
@@ -24,6 +24,24 @@ use crate::arrow::datatypes::SchemaRef;
 use crate::error::Result;
 use crate::physical_plan::ExecutionPlan;
 
+/// The table statistics
+pub struct Statistics {

Review comment:
       The Parquet crate calls these variables. I think consistency is good so 
maybe they should be renamed?
       num_rows: i64,
       total_byte_size: i64,




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to