alamb commented on code in PR #6096:
URL: https://github.com/apache/arrow-datafusion/pull/6096#discussion_r1181255556
##########
datafusion/expr/src/logical_plan/ddl.rs:
##########
@@ -273,3 +286,16 @@ pub struct DropView {
/// Dummy schema
pub schema: DFSchemaRef,
}
+
+/// Drops a schema
+#[derive(Clone, PartialEq, Eq, Hash)]
+pub struct DropCatalogSchema {
+ /// The schema name
+ pub name: OwnedSchemaReference,
+ /// If the schema exists
Review Comment:
```suggestion
/// If true, do not error if the schema does not exist
```
##########
datafusion/core/src/catalog/catalog.rs:
##########
@@ -124,6 +124,26 @@ pub trait CatalogProvider: Sync + Send {
"Registering new schemas is not supported".to_string(),
))
}
+
+ /// Removes a schema from this catalog. Implementations of this method
should return
+ /// errors if the schema exists but cannot be dropped. For example, in
DataFusion's
Review Comment:
❤️ --nice documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
