mr-brobot commented on code in PR #4161:
URL: https://github.com/apache/arrow-rs/pull/4161#discussion_r1181723694
##########
object_store/src/aws/mod.rs:
##########
@@ -1563,3 +1591,64 @@ mod tests {
}
}
}
+
+#[cfg(all(test, feature = "aws_profile"))]
+mod profile_tests {
+ use super::*;
+ use profile::ProfileProvider;
+ use region::RegionProvider;
+ use std::env;
+
+ impl RegionProvider for ProfileProvider {
+ fn get_region(&self) -> Option<String> {
Review Comment:
Agreed, this only tests the logic in `AmazonS3Builder` that falls back on
the profile region when a profile is provided.
I'll add a test in the `aws::profile` module that uses
[ProfileFiles](https://docs.rs/aws-config/latest/aws_config/profile/profile_file/struct.ProfileFiles.html)
to verify the configured profile region is actually what comes out of
`ProfileProvider::get_region`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
