mr-brobot commented on code in PR #4161:
URL: https://github.com/apache/arrow-rs/pull/4161#discussion_r1182869893
##########
object_store/src/aws/mod.rs:
##########
@@ -1563,3 +1591,64 @@ mod tests {
}
}
}
+
+#[cfg(all(test, feature = "aws_profile"))]
+mod profile_tests {
+ use super::*;
+ use profile::ProfileProvider;
+ use region::RegionProvider;
+ use std::env;
+
+ impl RegionProvider for ProfileProvider {
+ fn get_region(&self) -> Option<String> {
Review Comment:
I added a fake profile for testing in
`ProfileProvider::get_region_provider`. Let me know if you want to see more
tests or think this should be organized differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
