wjones127 commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1182661564
##########
cpp/src/arrow/dataset/file_parquet.h:
##########
@@ -136,6 +137,32 @@ class ARROW_DS_EXPORT ParquetFileFormat : public
FileFormat {
fs::FileLocator destination_locator) const override;
std::shared_ptr<FileWriteOptions> DefaultWriteOptions() override;
+
+ /// \brief A getter function to retrie‰ve the dataset encryption
configuration
+ std::shared_ptr<DatasetEncryptionConfiguration> GetDatasetEncryptionConfig()
const {
+ return dataset_encryption_config_;
+ }
+ /// \brief A getter function to retrieve the dataset decryption configuration
+ std::shared_ptr<DatasetDecryptionConfiguration> GetDatasetDecryptionConfig()
const {
+ return dataset_decryption_config_;
+ }
+ /// \brief A setter for DatasetEncryptionConfiguration
+ void SetDatasetEncryptionConfig(
+ std::shared_ptr<DatasetEncryptionConfiguration>
dataset_encryption_config) {
+ dataset_encryption_config_ = dataset_encryption_config;
+ }
+ /// \brief A setter for DatasetDecryptionConfiguration
+ void SetDatasetDecryptionConfig(
+ std::shared_ptr<DatasetDecryptionConfiguration>
dataset_decryption_config) {
+ dataset_decryption_config_ = dataset_decryption_config;
+ }
+
+ private:
+ // A configuration structure that provides per file encryption properties
for a dataset
+ std::shared_ptr<DatasetEncryptionConfiguration> dataset_encryption_config_ =
nullptr;
Review Comment:
You'll see in other header files we always use the `NULLPTR` macro:
```suggestion
std::shared_ptr<DatasetEncryptionConfiguration> dataset_encryption_config_
= NULLPTR;
```
##########
cpp/src/arrow/dataset/CMakeLists.txt:
##########
Review Comment:
Also seems like this file needs to be formatted, though not immediately
obvious what is wrong.
##########
cpp/src/arrow/dataset/file_parquet.h:
##########
@@ -136,6 +137,32 @@ class ARROW_DS_EXPORT ParquetFileFormat : public
FileFormat {
fs::FileLocator destination_locator) const override;
std::shared_ptr<FileWriteOptions> DefaultWriteOptions() override;
+
+ /// \brief A getter function to retrie‰ve the dataset encryption
configuration
+ std::shared_ptr<DatasetEncryptionConfiguration> GetDatasetEncryptionConfig()
const {
+ return dataset_encryption_config_;
+ }
+ /// \brief A getter function to retrieve the dataset decryption configuration
+ std::shared_ptr<DatasetDecryptionConfiguration> GetDatasetDecryptionConfig()
const {
+ return dataset_decryption_config_;
+ }
+ /// \brief A setter for DatasetEncryptionConfiguration
+ void SetDatasetEncryptionConfig(
+ std::shared_ptr<DatasetEncryptionConfiguration>
dataset_encryption_config) {
+ dataset_encryption_config_ = dataset_encryption_config;
+ }
+ /// \brief A setter for DatasetDecryptionConfiguration
+ void SetDatasetDecryptionConfig(
+ std::shared_ptr<DatasetDecryptionConfiguration>
dataset_decryption_config) {
+ dataset_decryption_config_ = dataset_decryption_config;
+ }
+
+ private:
+ // A configuration structure that provides per file encryption properties
for a dataset
+ std::shared_ptr<DatasetEncryptionConfiguration> dataset_encryption_config_ =
nullptr;
+ // A configuration structure that provides per file encryption and
decryption properties
+ // for a dataset
+ std::shared_ptr<DatasetDecryptionConfiguration> dataset_decryption_config_ =
nullptr;
Review Comment:
```suggestion
std::shared_ptr<DatasetDecryptionConfiguration> dataset_decryption_config_
= NULLPTR;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
