wjones127 commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1182782841
##########
cpp/src/arrow/dataset/CMakeLists.txt:
##########
@@ -166,6 +171,9 @@ endif()
if(ARROW_PARQUET)
add_arrow_dataset_test(file_parquet_test)
+if(PARQUET_REQUIRE_ENCRYPTION AND ARROW_DATASET)
+ add_arrow_dataset_test(dataset_encryption_test)
+endif()
Review Comment:
```suggestion
if(PARQUET_REQUIRE_ENCRYPTION AND ARROW_DATASET)
add_arrow_dataset_test(dataset_encryption_test)
endif()
```
##########
cpp/src/arrow/dataset/CMakeLists.txt:
##########
@@ -96,6 +96,11 @@ if(ARROW_BUILD_STATIC AND WIN32)
target_compile_definitions(arrow_dataset_static PUBLIC ARROW_DS_STATIC)
endif()
+if(ARROW_PARQUET AND PARQUET_REQUIRE_ENCRYPTION AND ARROW_DATASET)
+ # Add parquet to ARROW_TEST_STATIC_LINK_LIBS
+ list(APPEND ARROW_TEST_STATIC_LINK_LIBS parquet)
+endif()
Review Comment:
Got this when I ran `cmake-format cpp/src/arrow/dataset/CMakeLists.txt`:
```suggestion
if(ARROW_PARQUET
AND PARQUET_REQUIRE_ENCRYPTION
AND ARROW_DATASET)
# Add parquet to ARROW_TEST_STATIC_LINK_LIBS
list(APPEND ARROW_TEST_STATIC_LINK_LIBS parquet)
endif()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
