Dandandan commented on a change in pull request #8865:
URL: https://github.com/apache/arrow/pull/8865#discussion_r537882765



##########
File path: rust/datafusion/src/optimizer/utils.rs
##########
@@ -278,6 +280,8 @@ pub fn expr_sub_expressions(expr: &Expr) -> 
Result<Vec<Expr>> {
         Expr::ScalarVariable(_) => Ok(vec![]),
         Expr::Not(expr) => Ok(vec![expr.as_ref().to_owned()]),
         Expr::Sort { expr, .. } => Ok(vec![expr.as_ref().to_owned()]),
+        // Between is rewritten in the physical plan
+        Expr::Between { .. } => Ok(vec![]),

Review comment:
       I think this should be implement ed as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to