seddonm1 commented on a change in pull request #8865:
URL: https://github.com/apache/arrow/pull/8865#discussion_r537882849
##########
File path: rust/datafusion/src/optimizer/utils.rs
##########
@@ -91,6 +91,8 @@ pub fn expr_to_column_names(expr: &Expr, accum: &mut
HashSet<String>) -> Result<
Expr::AggregateUDF { args, .. } => exprlist_to_column_names(args,
accum),
Expr::ScalarFunction { args, .. } => exprlist_to_column_names(args,
accum),
Expr::ScalarUDF { args, .. } => exprlist_to_column_names(args, accum),
+ // Between is rewritten in the physical plan
+ Expr::Between { .. } => Ok(()),
Review comment:
Yes, you may be right. I am rewriting the Expr::Between into a set of
Binary operations prior to that so I don't think this should ever be invoked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
