rtpsw commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1185378305
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -370,13 +475,20 @@ class KeyHasher {
column_arrays_[k] =
ColumnArrayFromArrayDataAndMetadata(array_data, metadata_[k], i,
length);
}
+ // write directly to the cache
Hashing64::HashMultiColumn(column_arrays_, &ctx_, hashes_.data() + i);
}
- batch_ = batch;
+#ifndef NDEBUG
+ DebugSync(*node_) << "key hasher " << index_ << " got hashes "
+ << compute::internal::GenericToString(hashes_) <<
std::endl;
+#endif
Review Comment:
Yeah, that should work for removing those `#ifndef` used for `DebugSync`.
I'll look into this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
