rtpsw commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1189772896


##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -680,6 +816,7 @@ class InputState {
   Result<bool> AdvanceAndMemoize(OnType ts) {
     // Advance the right side row index until we reach the latest right row 
(for each key)
     // for the given left timestamp.
+    DEBUG_SYNC(node_, "Advancing input ", index_, DEBUG_MANIP(std::endl));

Review Comment:
   Note that there are a 
[couple](https://github.com/apache/arrow/pull/34392/commits/85328512f4899ca92ce5404f442036f54d6ab3ee#diff-5493b6ae7ea2a4d5cfb581034c076e9c4be7608382168de6d1301ef67b6c01eeR1331)
 of 
[examples](https://github.com/apache/arrow/pull/34392/commits/85328512f4899ca92ce5404f442036f54d6ab3ee#diff-5493b6ae7ea2a4d5cfb581034c076e9c4be7608382168de6d1301ef67b6c01eeR1681)
 where `std::endl` is used in the middle of a message, so `DEBUG_MANIP` would 
be useful even if we had `DEBUG_SYNC_LINE`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to